New York’s attempts to push financial institutions to drop their relationships with the National Rifle Association over the group’s pro-gun views ran afoul of the Constitution.