The partnership between the National Rifle Association (NRA) and the architect of its legal strategy for the last half-decade is now ending.